Rely on backend build path and bootstrap metadata to easily build from source #2582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webknjaz
reviewed
Feb 27, 2021
webknjaz
reviewed
Feb 27, 2021
| @@ -1,6 +1,5 @@ | |||
| [build-system] | |||
| requires = [ | |||
| "setuptools >= 40.8", | |||
| "wheel", | |||
| ] | |||
| build-backend = "setuptools.build_meta" | |||
There was a problem hiding this comment.
Have you considered having maybe a completely separate backend?
There was a problem hiding this comment.
I have. Maybe something that vendors all of the dependencies or just hard-codes the behavior especially for setuptools. It's not out of consideration yet.
There was a problem hiding this comment.
Yep, that's exactly what I had in my mind.
webknjaz
reviewed
Feb 27, 2021
webknjaz
reviewed
Feb 27, 2021
jaraco
force-pushed
the
feature/2550-build-from-source
branch
from
9680d02 to
1da02dc
Compare
jaraco
force-pushed
the
feature/2550-build-from-source
branch
from
1f5b82f to
61b3376
Compare
This was referenced Mar 8, 2021
This was referenced Mar 15, 2021
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1644.