Fix crash formatting error message #4809
Open
+8
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngoldbaum
force-pushed
the
fix-error-crash
branch
from
d3f193b to
e5f740d
Compare
Avasam
reviewed
Jan 18, 2025
| @@ -291,10 +291,15 @@ def _validate_py_limited_api(self) -> None: | |||
| raise ValueError(f"py-limited-api must match '{PY_LIMITED_API_PATTERN}'") | |||
|
|
|||
| if sysconfig.get_config_var("Py_GIL_DISABLED"): | |||
| # sys.abiflags is only defined on POSIX | |||
| if getattr(sys, "abiflags", ""): | |||
There was a problem hiding this comment.
I assume you just mean to check that the attribute exists, and not the truthiness of its value.
Suggested change
| if getattr(sys, "abiflags", ""): | |
| if hasattr(sys, "abiflags"): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Avoids an
AttributeErroron non-posix systems, wheresys.abiflagsisn't set.Closes #4807
This code was originally authored by @abravalheri in #4424. I think the non-POSIX limitation was just missed there.
That PR didn't add tests for this error so I thought it was fair game to fix it without a test as well 🙃.
Pull Request Checklist
newsfragments/.(See documentation for details)