-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Use license_files instead of license_file #2676
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Czaki
added a commit
to napari/napari
that referenced
this pull request
Jun 21, 2023
# Description During installation from source, the following message is presented: ``` ******************************************************************************** The license_file parameter is deprecated, use license_files instead. By 2023-Oct-30, you need to update your project and remove deprecated calls or your builds will no longer be supported. See https://setuptools.pypa.io/en/latest/userguide/declarative_config.html for details. ******************************************************************************** ``` This PR changes the parameter name and bumps the minimum setuptools version. Maybe it is possible to use lower version, but they do not put such information anywhere. # References pypa/setuptools#2676 ## Type of change <!-- Please delete options that are not relevant. --> - [x] Bug-fix (non-breaking change which fixes an issue)
Czaki
added a commit
to napari/napari
that referenced
this pull request
Jun 21, 2023
# Description During installation from source, the following message is presented: ``` ******************************************************************************** The license_file parameter is deprecated, use license_files instead. By 2023-Oct-30, you need to update your project and remove deprecated calls or your builds will no longer be supported. See https://setuptools.pypa.io/en/latest/userguide/declarative_config.html for details. ******************************************************************************** ``` This PR changes the parameter name and bumps the minimum setuptools version. Maybe it is possible to use lower version, but they do not put such information anywhere. # References pypa/setuptools#2676 ## Type of change <!-- Please delete options that are not relevant. --> - [x] Bug-fix (non-breaking change which fixes an issue)
Czaki
added a commit
to napari/napari
that referenced
this pull request
Jun 21, 2023
# Description During installation from source, the following message is presented: ``` ******************************************************************************** The license_file parameter is deprecated, use license_files instead. By 2023-Oct-30, you need to update your project and remove deprecated calls or your builds will no longer be supported. See https://setuptools.pypa.io/en/latest/userguide/declarative_config.html for details. ******************************************************************************** ``` This PR changes the parameter name and bumps the minimum setuptools version. Maybe it is possible to use lower version, but they do not put such information anywhere. # References pypa/setuptools#2676 ## Type of change <!-- Please delete options that are not relevant. --> - [x] Bug-fix (non-breaking change which fixes an issue)
Czaki
added a commit
to napari/napari
that referenced
this pull request
Jun 21, 2023
# Description During installation from source, the following message is presented: ``` ******************************************************************************** The license_file parameter is deprecated, use license_files instead. By 2023-Oct-30, you need to update your project and remove deprecated calls or your builds will no longer be supported. See https://setuptools.pypa.io/en/latest/userguide/declarative_config.html for details. ******************************************************************************** ``` This PR changes the parameter name and bumps the minimum setuptools version. Maybe it is possible to use lower version, but they do not put such information anywhere. # References pypa/setuptools#2676 ## Type of change <!-- Please delete options that are not relevant. --> - [x] Bug-fix (non-breaking change which fixes an issue)
melissawm
pushed a commit
to melissawm/napari
that referenced
this pull request
Jul 3, 2023
# Description During installation from source, the following message is presented: ``` ******************************************************************************** The license_file parameter is deprecated, use license_files instead. By 2023-Oct-30, you need to update your project and remove deprecated calls or your builds will no longer be supported. See https://setuptools.pypa.io/en/latest/userguide/declarative_config.html for details. ******************************************************************************** ``` This PR changes the parameter name and bumps the minimum setuptools version. Maybe it is possible to use lower version, but they do not put such information anywhere. # References pypa/setuptools#2676 ## Type of change <!-- Please delete options that are not relevant. --> - [x] Bug-fix (non-breaking change which fixes an issue)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Since v56.0.0 / #2620:
So
license_file
(str
) isn't exactly the same aslicense_files
(list-comma
), but is it close enough to put it in this table? Would it need a note?For example, if you have
license_file = LICENSE.txt
, you can replace that withlicense_files = LICENSE.txt
Pull Request Checklist
changelog.d/
.(See documentation for details)