Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Developer Guide docs #76

Open
eh-am opened this issue May 12, 2022 · 0 comments
Open

Improve Developer Guide docs #76

eh-am opened this issue May 12, 2022 · 0 comments

Comments

@eh-am
Copy link
Contributor

eh-am commented May 12, 2022

Few things I noticed while setting up in a new machine:

make build-third-party-dependencies

is such a hindrance (you gotta install a bunch of stuff), and for a lot of people contributing to pyroscope it's not really needed. Maybe we should make the ENABLED_SPIES=none more proeminent.


error [email protected]: The engine "node" is incompatible with this module. Expected version "^12.20 || ^14.15 || ^16". Got "17.9.0"

We have to tell people to use nvm (or any other kind of version management like asdf) and follow the node version set up in the .nvmrc file


Running lerna bootstrap is required, otherwise the webapp fails trying to resolve @pyroscope/flamegraph

21:11:58           frontend | @pyroscope/webapp: ERROR in ./javascript/pages/ContinuousSingleView.tsx 5:0-59
21:11:58           frontend | @pyroscope/webapp: Module not found: Error: Can't resolve '@pyroscope/flamegraph' in '/home/eduardo/work/pyroscope/pyroscope/webapp/javascript/pages'

Some of the css was broken
2022-05-11-213216_1160x298_scrot

Trying again solved it (???)


It took some time to build the first time
I think it was due to the @pyroscope/flamegraph still being built,
Plus it was difficult to tell when things were ready (ie when should i be able to access localhost:4040 ?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant