feat: graphviz visualization support #1759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petethepig
commented
Nov 24, 2022
| const dataUnavailable = | ||
| !this.state.flamebearer || this.state.flamebearer.names.length <= 1; | ||
| const panes = decidePanesOrder( | ||
| this.state.view, | ||
| flameGraphPane, | ||
| graphvizPane, |
There was a problem hiding this comment.
I did this just to test it, we should move it somewhere else
petethepig
commented
Nov 24, 2022
| return `N${srcIndex} -> N${dstIndex} ${renderLabels(labels)}`; | ||
| } | ||
|
|
||
| export default function toGraphviz(p: Profile): string { |
There was a problem hiding this comment.
this function is not ready yet, hence all the TODOs
Codecov ReportBase: 66.35% // Head: 66.98% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1759 +/- ##
==========================================
+ Coverage 66.35% 66.98% +0.64%
==========================================
Files 170 173 +3
Lines 5554 5875 +321
Branches 1252 1575 +323
==========================================
+ Hits 3685 3935 +250
- Misses 1860 1929 +69
- Partials 9 11 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
merged with latest main |
size-limit report 📦
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
work in progress. /cc @pavelpashkovsky