Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pprof parsing): initialize function to zero values before parsing #1837

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

korniltsev
Copy link
Collaborator

@korniltsev korniltsev commented Feb 7, 2023

before this change, when the parser is pooled if a function message has no some field it would reuse some garbage from previous pool usage

@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2023

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
webapp/public/assets/app.js 1006.82 KB (0%) 20.2 s (0%) 3.7 s (-22.37% 🔽) 23.9 s
webapp/public/assets/app.css 19.88 KB (0%) 398 ms (0%) 0 ms (+100% 🔺) 398 ms
webapp/public/assets/styles.css 9.6 KB (0%) 192 ms (0%) 0 ms (+100% 🔺) 192 ms
packages/pyroscope-flamegraph/dist/index.js 632.77 KB (0%) 12.7 s (0%) 2 s (+0.15% 🔺) 14.7 s
packages/pyroscope-flamegraph/dist/index.node.js 633.47 KB (0%) 12.7 s (0%) 854 ms (+4.77% 🔺) 13.6 s
packages/pyroscope-flamegraph/dist/index.css 8.11 KB (0%) 163 ms (0%) 0 ms (+100% 🔺) 163 ms

@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Base: 63.28% // Head: 63.28% // No change to project coverage 👍

Coverage data is based on head (0f885c4) compared to base (c84bcd3).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1837   +/-   ##
=======================================
  Coverage   63.28%   63.28%           
=======================================
  Files         175      175           
  Lines        5912     5912           
  Branches     1587     1587           
=======================================
  Hits         3741     3741           
  Misses       2160     2160           
  Partials       11       11           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@korniltsev korniltsev merged commit 692f11b into main Feb 7, 2023
@korniltsev korniltsev deleted the fix/pprof_parsing_uninitialized_functoin branch February 7, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants