Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(panel-plugin): don't load CSS file since it's loaded using css modules #891

Merged
merged 1 commit into from
Feb 24, 2022

Conversation

eh-am
Copy link
Collaborator

@eh-am eh-am commented Feb 24, 2022

Otherwise grafana will try to load it and raise an exception.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
webapp/public/assets/app.js 446.15 KB (0%) 9 s (0%) 919 ms (+3.38% 🔺) 9.9 s

@codecov
Copy link

codecov bot commented Feb 24, 2022

Codecov Report

Merging #891 (5bc37ed) into main (0477cff) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #891   +/-   ##
=======================================
  Coverage   66.09%   66.09%           
=======================================
  Files          86       86           
  Lines        3120     3120           
  Branches      611      611           
=======================================
  Hits         2062     2062           
  Misses       1026     1026           
  Partials       32       32           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8856af1...5bc37ed. Read the comment docs.

@pyroscopebot
Copy link
Collaborator

Screenshots

Throughput Throughput
Disk Usage Disk Usage
Memory Memory
Upload Errors (Total) Upload Errors (Total)
Successful Uploads (Total) Successful Uploads (Total)
CPU Utilization CPU Utilization

Generated by 🚫 dangerJS against f009f80

@eh-am eh-am changed the title fix(panel-plugin): don't load CSS file since it's loaded using css fix(panel-plugin): don't load CSS file since it's loaded using css modules Feb 24, 2022
@eh-am eh-am marked this pull request as ready for review February 24, 2022 16:04
@eh-am eh-am merged commit 183eaa0 into main Feb 24, 2022
@eh-am eh-am deleted the fix/dont-load-css branch February 24, 2022 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants