Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST: update mock download parameterization #134

Open
aburrell opened this issue Nov 27, 2023 · 0 comments
Open

TST: update mock download parameterization #134

aburrell opened this issue Nov 27, 2023 · 0 comments
Labels
enhancement New feature or request
Milestone
1.0.0

Comments

@aburrell
Copy link
Member

Description

Update the mock download parameterization to use the appropriate key after pysat issue pysat/pysat#1158 is implemented.

Potential impact

  • Is the feature related to an existing problem? Cannot fully test TestMockDownloads on CI
  • How critical is this feature to your workflow? Necessary
  • How wide of an impact to you anticipate this enhancement having? Allow potential errors to be caught
  • Would this break any existing functionality? No

Potential solution(s)

Update test suite once a new pysat key is available

Alternatives

Find a way to re-create the inst_dict locally.

Additional context

See: #133
@aburrell aburrell added the enhancement New feature or request label Nov 27, 2023
@aburrell aburrell added this to the 1.0.0 milestone Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
1 participant
@aburrell