Modernize #61
Merged
Modernize #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No longer needed these days.
nicoddemus
approved these changes
Jan 18, 2024
.github/workflows/run-checks.yml
Outdated
| - environment: "py38" | ||
| python: "3.8" | ||
| - environment: "py39" |
There was a problem hiding this comment.
No need to change, but realized that matrix.environment is not used at all, so this matrix could be simplified:
matrix:
python: ["3.8", "3.9", "3.10", "3.11", "3.12"]There was a problem hiding this comment.
Thanks, I also removed the pip upgrade bit since setup-python already does this as I've learned now.
| build-backend = "setuptools.build_meta" | ||
|
|
||
| [project] | ||
| name = "pytest-{{cookiecutter.plugin_name}}" |
There was a problem hiding this comment.
We do not need any directive for setuptools to work with the src layout? Neat.
There was a problem hiding this comment.
Yes it has "automatic discovery" https://setuptools.pypa.io/en/latest/userguide/package_discovery.html#automatic-discovery
I verified that the sdist and wheel look good (possible I missed something but I don't think so)
`testdir` is soft-deprecated in pytest, `pytester` is the replacement. Fix #51
This was referenced Jan 19, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modernizes things I could see, please see the commits.