Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace lib2to3 with fissix #16

Closed
jayvdb opened this issue Nov 14, 2020 · 6 comments
Closed

Replace lib2to3 with fissix #16

jayvdb opened this issue Nov 14, 2020 · 6 comments

Comments

@jayvdb
Copy link
Contributor

jayvdb commented Nov 14, 2020

https://github.com/jreese/fissix is a maintained library derived from lib2to3.

https://github.com/PyCQA/modernize recently switched to using fissix.

@jayvdb
Copy link
Contributor Author

jayvdb commented Nov 14, 2020

This would be the end of #4

@dosas
Copy link
Contributor

dosas commented Jan 18, 2021

Using fissix would require us to drop support for py34 and py35 but since the are EOL I think taht would be okay?

@schollii
Copy link
Collaborator

3.4 already dropped. Dropping 3.5 fine too.

@schollii
Copy link
Collaborator

However, from the 2to3 docs on python website:

Python 3.9 switched to a PEG parser (see PEP 617) while lib2to3 is using a less flexible LL(1) parser. Python 3.10 includes new language syntax that is not parsable by lib2to3’s LL(1) parser (see PEP 634).

This indicates that lib2to3, or fissix, may not be able to parse some Python code, starting with Python 3.10. Although it is likely that in the context of tests, this will not be an issue for another while.

I will leave this issue open until 3.13 removes it. But most likely, it will simply be necessary to use 3.12 or earlier: the version of python used to run the conversion script is independent of the version used to run a user's test suite with pytest and even moreso to run the user's app being tested by the test suite.

So I will likely close this issue. Let me know if I'm missing anything.

@dosas
Copy link
Contributor

dosas commented Apr 16, 2024

#17

@cclauss
Copy link
Contributor

cclauss commented Apr 25, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants