Fix caching of parameterized fixtures #12627
Closed
+45
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fix for Issue pytest-dev#6541 caused regression where cache hits became cache misses, unexpectedly. Fixes pytest-dev#6962 --------- Co-authored-by: Nicolas Simonds <[email protected]> Co-authored-by: Bruno Oliveira <[email protected]> Co-authored-by: Ran Benita <[email protected]>
psf-chronographer
bot
added
the
bot:chronographer:provided
0xDEC0DE
changed the title
|
We intentionally didn't backport it, it is too disruptive for a patch release. But worry not, we are intending to release 8.3 this weekend so you don't need to wait long. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix for Issue #6541 caused regression where cache hits became cache misses, unexpectedly.
Backport of commit d489247
Fixes #6962
Co-authored-by: Nicolas Simonds [email protected]
Co-authored-by: Bruno Oliveira [email protected]
Co-authored-by: Ran Benita [email protected]