-
-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switched from __dataclass_transform__() to typing.dataclass_transform() #1158
Merged
hynek
merged 7 commits into
python-attrs:main
from
superbobry:typing.dataclass_transform
Jul 6, 2023
Merged
Switched from __dataclass_transform__() to typing.dataclass_transform() #1158
hynek
merged 7 commits into
python-attrs:main
from
superbobry:typing.dataclass_transform
Jul 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superbobry
force-pushed
the
typing.dataclass_transform
branch
from
June 28, 2023 22:08
5312d68
to
401be1c
Compare
superbobry
force-pushed
the
typing.dataclass_transform
branch
from
June 29, 2023 09:19
cad8039
to
5a69034
Compare
I'll leave the review to our resident typing czar but please add a news fragment. |
for more information, see https://pre-commit.ci
superbobry
force-pushed
the
typing.dataclass_transform
branch
from
June 29, 2023 11:29
5eb40bf
to
d9fa361
Compare
Tiiin, it's greeeeeen! |
I'll install this branch into a bunch of our codebases and see if it's gucci. |
Seems to work! |
Tinche
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces the non-standard
__dataclass_transform__()
in type stubs withtyping.dataclass_transform()
, introduced in PEP-681.The only difference between the two decorators is the naming of one parameter:
field_descriptors=
in__dataclass_transform__()
is nowfield_specifiers=
.Pull Request Check List
Our CI fails if coverage is not 100%.
.pyi
).tests/typing_example.py
.attr/__init__.pyi
, they've also been re-imported inattrs/__init__.pyi
.docs/api.rst
by hand.@attr.s()
have to be added by hand too.versionadded
,versionchanged
, ordeprecated
directives.The next version is the second number in the current release + 1.
The first number represents the current year.
So if the current version on PyPI is 22.2.0, the next version is gonna be 22.3.0.
If the next version is the first in the new year, it'll be 23.1.0.
.rst
files is written using semantic newlines.changelog.d
.