Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider strictly following SemVer #4266

Closed
2 tasks done
max-wittig opened this issue Jul 8, 2021 · 1 comment
Closed
2 tasks done

Consider strictly following SemVer #4266

max-wittig opened this issue Jul 8, 2021 · 1 comment

Comments

@max-wittig
Copy link

max-wittig commented Jul 8, 2021

  • I have searched the issues of this repo and believe that this is not a duplicate.
  • I have searched the documentation and believe that my question is not covered.

Issue

Might be a separate issue, but it seems poetry 1.0.10 is not working anymore for new projects.
With this minor release from 1.0.10 to 1.1.X lockfiles are actually not compatible anymore as the format was changed in 1.1. According to SemVer such breaking changes would require a new major version (2.X).

In a patch release (1.1.4), the new installer was added and enabled by default, which I would feel like would at least be worth a minor release. We still have to disable the new installer in some of our projects, as it breaks (#3336)

Is it planned to follow SemVer more strictly with poetry? That would make it easier for everybody to upgrade faster.

Don't fear high version numbers.

@dlouzan @ercanucan

@finswimmer
Copy link
Member

Hello @max-wittig,

poetry tries to follow SemVer. But as discussed in several places there will be always changes that lead to a disagreement between different people which version number would be correct.

Related to your points:

poetry 1.1.* can handle lock file created with poetry < 1.1 and >=1.1. So this a backwards compatibility and as such a minor version bump is correct.

Regarding the installer: Whether it should be a patch, minor or major version is always related to the intention of maintainer. Even a small bugfix can be a breaking change to someone else (This is discussed in several places as well). The intention with the new installer wasn't to break someones work, but to change how something is done. (I'm still not able to reproduce the problems reported by others 🤔 )

Don't fear high version numbers.

I fully agree here with you 😄

fin swimmer

PS: I will convert this issue to a discussion

@python-poetry python-poetry locked and limited conversation to collaborators Jul 9, 2021

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants