From 2464871144f99f03bc80c3f22493e020368921e4 Mon Sep 17 00:00:00 2001 From: Conengmo <33519926+Conengmo@users.noreply.github.com> Date: Wed, 27 Nov 2024 15:02:52 +0100 Subject: [PATCH 1/5] selenium<4.27.0 --- requirements-dev.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/requirements-dev.txt b/requirements-dev.txt index 4c416c539..3834e1e8b 100644 --- a/requirements-dev.txt +++ b/requirements-dev.txt @@ -30,7 +30,7 @@ pycodestyle pydata-sphinx-theme pytest scipy -selenium +selenium<4.27.0 setuptools_scm sphinx types-requests From 7f037b0be24398a5bec6d2031c911e1273b3129a Mon Sep 17 00:00:00 2001 From: Conengmo <33519926+Conengmo@users.noreply.github.com> Date: Wed, 27 Nov 2024 15:08:18 +0100 Subject: [PATCH 2/5] fix deprecated selenium call --- requirements-dev.txt | 2 +- tests/selenium/test_geojson_selenium.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/requirements-dev.txt b/requirements-dev.txt index 3834e1e8b..4c416c539 100644 --- a/requirements-dev.txt +++ b/requirements-dev.txt @@ -30,7 +30,7 @@ pycodestyle pydata-sphinx-theme pytest scipy -selenium<4.27.0 +selenium setuptools_scm sphinx types-requests diff --git a/tests/selenium/test_geojson_selenium.py b/tests/selenium/test_geojson_selenium.py index 1908adb83..92790fa91 100644 --- a/tests/selenium/test_geojson_selenium.py +++ b/tests/selenium/test_geojson_selenium.py @@ -35,4 +35,4 @@ def test_geojson(driver): ) assert control_label.text == "geojson" control_input = control_label.find_element(By.CSS_SELECTOR, value="input") - assert control_input.get_attribute("checked") is None + assert control_input.get_dom_attribute("checked") is None From 08d7db816d8fc0fb7b4dfeaf7193a41ef90014c3 Mon Sep 17 00:00:00 2001 From: Conengmo <33519926+Conengmo@users.noreply.github.com> Date: Wed, 27 Nov 2024 15:14:42 +0100 Subject: [PATCH 3/5] use get_property --- tests/selenium/test_geojson_selenium.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/selenium/test_geojson_selenium.py b/tests/selenium/test_geojson_selenium.py index 92790fa91..b9f2c7b42 100644 --- a/tests/selenium/test_geojson_selenium.py +++ b/tests/selenium/test_geojson_selenium.py @@ -35,4 +35,4 @@ def test_geojson(driver): ) assert control_label.text == "geojson" control_input = control_label.find_element(By.CSS_SELECTOR, value="input") - assert control_input.get_dom_attribute("checked") is None + assert control_input.get_property("checked") is False From 0a1e41146aef2fc780df9ee9651b2ac2e5e98e62 Mon Sep 17 00:00:00 2001 From: Conengmo <33519926+Conengmo@users.noreply.github.com> Date: Wed, 27 Nov 2024 15:22:34 +0100 Subject: [PATCH 4/5] Revert "use get_property" This reverts commit 08d7db816d8fc0fb7b4dfeaf7193a41ef90014c3. --- tests/selenium/test_geojson_selenium.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/selenium/test_geojson_selenium.py b/tests/selenium/test_geojson_selenium.py index b9f2c7b42..92790fa91 100644 --- a/tests/selenium/test_geojson_selenium.py +++ b/tests/selenium/test_geojson_selenium.py @@ -35,4 +35,4 @@ def test_geojson(driver): ) assert control_label.text == "geojson" control_input = control_label.find_element(By.CSS_SELECTOR, value="input") - assert control_input.get_property("checked") is False + assert control_input.get_dom_attribute("checked") is None From ba28947cd521d5972c91c44e750f4d02177033fd Mon Sep 17 00:00:00 2001 From: Conengmo <33519926+Conengmo@users.noreply.github.com> Date: Wed, 27 Nov 2024 15:22:36 +0100 Subject: [PATCH 5/5] Revert "fix deprecated selenium call" This reverts commit 7f037b0be24398a5bec6d2031c911e1273b3129a. --- requirements-dev.txt | 2 +- tests/selenium/test_geojson_selenium.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/requirements-dev.txt b/requirements-dev.txt index 4c416c539..3834e1e8b 100644 --- a/requirements-dev.txt +++ b/requirements-dev.txt @@ -30,7 +30,7 @@ pycodestyle pydata-sphinx-theme pytest scipy -selenium +selenium<4.27.0 setuptools_scm sphinx types-requests diff --git a/tests/selenium/test_geojson_selenium.py b/tests/selenium/test_geojson_selenium.py index 92790fa91..1908adb83 100644 --- a/tests/selenium/test_geojson_selenium.py +++ b/tests/selenium/test_geojson_selenium.py @@ -35,4 +35,4 @@ def test_geojson(driver): ) assert control_label.text == "geojson" control_input = control_label.find_element(By.CSS_SELECTOR, value="input") - assert control_input.get_dom_attribute("checked") is None + assert control_input.get_attribute("checked") is None