-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
skip-news
and type-tests
badges
#421
Comments
This comment was marked as resolved.
This comment was marked as resolved.
In my experience, |
Please see #363 for the previous discussion in this matter. |
IMHO the opt-out model we currently have works well enough and makes the check more predictable. We could add custom rules for docs or tests, but they would have to be documented and there are cases where a NEWS entry is still required. |
We could also implement this for the |
This might come in handy for python/cpython#94808 |
The short story
It would be nice if
skip-news
label is automatically added when both conditions are true:type-tests
badgeNEWS
entryExample: python/cpython#30472
Long version
I love working on unit-tests in CPython, but I have a small problem. When I submit a PR the CI is usually red, because
NEWS
check fails: there's noNEWS
entry.Most of the reviewers say that test-only changes should not go to
NEWS
(and I agree). But, right now the only way for non-members is to wait for someone who will putskip-news
badge manually to turn the CI to be green. I don't think that precious time should be spent on that! 🙂Otherwise, it is less-likely to get a review (because PR has this red cross as its status, some people might think that something is broken).
For new contributors this might be even more problematic.
The text was updated successfully, but these errors were encountered: