You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After a connection loss _SSLProtocolTransport.is_closing() continues to return False.
I'm really struggling to get to the bottom of it, but currently it seems like is_closing() should do something like return self._ssl_protocol._transport.is_closing() (except transport is set to None when the connection is lost, so maybe could just check for that instead?).
This is currently causing handlers in aiohttp to not get cancelled correctly (potentially running forever), when an SSL transport is used.
Plus a workaround that demonstrates that atleast connection_lost() gets called in both cases, resulting in protocol.transport getting set to None: aio-libs/aiohttp#7180
I'm just trying to figure out if something should be fixed in asyncio, and also whether that PR is possibly the correct way to do this or not. I'm wondering if it is already the correct way to check for this and something is just going wrong in asyncio..
The text was updated successfully, but these errors were encountered:
After a connection loss _SSLProtocolTransport.is_closing() continues to return
False
.I'm really struggling to get to the bottom of it, but currently it seems like
is_closing()
should do something likereturn self._ssl_protocol._transport.is_closing()
(except transport is set toNone
when the connection is lost, so maybe could just check for that instead?).This is currently causing handlers in aiohttp to not get cancelled correctly (potentially running forever), when an SSL transport is used.
Full details and (aiohttp) reproducer:
aio-libs/aiohttp#7172 (comment)
Plus a workaround that demonstrates that atleast connection_lost() gets called in both cases, resulting in protocol.transport getting set to
None
:aio-libs/aiohttp#7180
I'm just trying to figure out if something should be fixed in asyncio, and also whether that PR is possibly the correct way to do this or not. I'm wondering if it is already the correct way to check for this and something is just going wrong in asyncio..
The text was updated successfully, but these errors were encountered: