gh-119180: Add discussion of annotations to the 3.14 What's New #124393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bedevere-app
bot
added
awaiting core review
docs
29 tasks
AlexWaygood
reviewed
Sep 24, 2024
Comment on lines
+84
to
+88
| annotations. Annotations may be evaluated in the :attr:`~annotationlib.Format.VALUE` | ||
| format (which evaluates annotations to runtime values, similar to the behavior in | ||
| earlier Python versions), the :attr:`~annotationlib.Format.FORWARDREF` format | ||
| (which replaces undefined names with special markers), and the | ||
| :attr:`~annotationlib.Format.SOURCE` format (which returns annotations as strings). |
There was a problem hiding this comment.
These will render as VALUE, FORWARDREF, SOURCE. Is that what we want, or would Format.VALUE, Format.FORWARDREF and Format.SOURCE be better?
There was a problem hiding this comment.
I did intend these to render as VALUE etc. Do you think adding Format is better?
There was a problem hiding this comment.
I think I'd weakly prefer Format.VALUE, but it might make the markup quite verbose, and I don't have a strong opinion :-)
Co-authored-by: Alex Waygood <[email protected]>
|
(As I mentioned offline, my high-level feedback would be that it would be nice to have some more positive content about the motivations and advantages of this change. Overall the tone is a bit gloomy currently -- but it's overall a great change, that we have lots of reasons for! :-D ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--124393.org.readthedocs.build/