Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-123884 Tee of tee was not producing n independent iterators #124490

Merged
merged 9 commits into from
Sep 25, 2024
Merged

gh-123884 Tee of tee was not producing n independent iterators #124490

merged 9 commits into from
Sep 25, 2024

Conversation

rhettinger
Copy link
Contributor

@rhettinger rhettinger commented Sep 25, 2024 •
edited by github-actions bot
Loading

  • Eliminates the code path that reused a tee object input as part of the output.
  • Updated the rough equivalent recipe to have better fidelity to the actual C code.
  • Removed a note about using the tee input. It is generically true of all iterator pass throughs and the note made it seem like a caution specific to tee where a tee-of-a-tee is the exception to the rule.

📚 Documentation preview 📚: https://cpython-previews--124490.org.readthedocs.build/

@rhettinger rhettinger added type-bug An unexpected behavior, bug, or error needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Sep 25, 2024
@bedevere-app bedevere-app bot mentioned this pull request Sep 25, 2024
Closed
ericvsmith
ericvsmith approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@ericvsmith ericvsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the one noted nit, this all looks good to me. I verified the "roughly equivalent" code, but not the code in test_itertools.py (I figure the test suite will do that job).

Doc/library/itertools.rst Show resolved Hide resolved
Lib/test/test_itertools.py Show resolved Hide resolved
@rhettinger rhettinger merged commit 909c6f7 into python:main Sep 25, 2024
39 checks passed
@miss-islington-app
Copy link

Thanks @rhettinger for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @rhettinger, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 909c6f718913e713c990d69e6d8a74c05f81e2c2 3.13

@rhettinger rhettinger deleted the tee1 branch September 25, 2024 20:38
@miss-islington-app
Copy link

Sorry, @rhettinger, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 909c6f718913e713c990d69e6d8a74c05f81e2c2 3.12

emilyemorehouse added a commit to lysnikolaou/cpython that referenced this pull request Sep 26, 2024
@emilyemorehouse
Merge branch 'main' into fix-help-double-prompt
4cdb3ae 
* main: (69 commits)
  Add "annotate" SET_FUNCTION_ATTRIBUTE bit to dis. (python#124566)
  pythongh-124412: Add helpers for converting annotations to source format (python#124551)
  pythongh-119180: Disallow instantiation of ConstEvaluator objects (python#124561)
  For-else deserves its own section in the tutorial (python#123946)
  Add 3.13 as a version option to the crash issue template (python#124560)
  pythongh-123242: Note that type.__annotations__ may not exist (python#124557)
  pythongh-119180: Make FORWARDREF format look at __annotations__ first (python#124479)
  pythonGH-58058: Add quick reference for `ArgumentParser` to argparse docs (pythongh-124227)
  pythongh-41431: Add `datetime.time.strptime()` and `datetime.date.strptime()` (python#120752)
  pythongh-102450: Add ISO-8601 alternative for midnight to `fromisoformat()` calls. (python#105856)
  pythongh-124370: Add "howto" for free-threaded Python (python#124371)
  pythongh-121277: Allow `.. versionadded:: next` in docs (pythonGH-121278)
  pythongh-119400:  make_ssl_certs: update reference test data automatically, pass in expiration dates as parameters python#119400  (pythonGH-119401)
  pythongh-119180: Avoid going through AST and eval() when possible in annotationlib (python#124337)
  pythongh-124448: Update Windows builds to use Tcl/Tk 8.6.15 (pythonGH-124449)
  pythongh-123884 Tee of tee was not producing n independent iterators (pythongh-124490)
  pythongh-124378: Update test_ttk for Tcl/Tk 8.6.15 (pythonGH-124542)
  pythongh-124513: Check args in framelocalsproxy_new() (python#124515)
  pythongh-101100: Add a table of class attributes to the "Custom classes" section of the data model docs (python#124480)
  Doc: Use ``major.minor`` for documentation distribution archive filenames (python#124489)
  ...
rhettinger added a commit to rhettinger/cpython that referenced this pull request Oct 8, 2024
@rhettinger
pythongh-123884 Tee of tee was not producing n independent iterators (p…
3509123 
…ythongh-124490)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericvsmith ericvsmith ericvsmith approved these changes

Assignees

@rhettinger rhettinger

Labels
needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rhettinger @ericvsmith