From 8f47aa2c0e4afadd9e669cf5223e0d2d0a24a4f5 Mon Sep 17 00:00:00 2001 From: Brandt Bucher Date: Tue, 19 Nov 2019 16:59:32 -0800 Subject: [PATCH] bpo-38823: Fix refleak in marshal init error path (GH-17260) (cherry picked from commit 33b671e72450bf4b5a946ce0dde6b7fe21150108) Co-authored-by: Brandt Bucher --- Python/marshal.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Python/marshal.c b/Python/marshal.c index b2daff2c8a3bef..c6a06e8c239764 100644 --- a/Python/marshal.c +++ b/Python/marshal.c @@ -1829,6 +1829,9 @@ PyMarshal_Init(void) PyObject *mod = PyModule_Create(&marshalmodule); if (mod == NULL) return NULL; - PyModule_AddIntConstant(mod, "version", Py_MARSHAL_VERSION); + if (PyModule_AddIntConstant(mod, "version", Py_MARSHAL_VERSION) < 0) { + Py_DECREF(mod); + return NULL; + } return mod; }