gh-94808: Coverage: Test uppercase string literal prefixes #95925
Conversation
mdboom
commented
Aug 12, 2022
•
mdboom
commented
- Issue: Metabug: Improving C-level coverage #94808
mdboom
added
skip news
needs backport to 3.11
Lib/test/test_string_literals.py
Outdated
| self.assertEqual(eval(r""" R'\x01' """), '\\x01') | ||
| self.assertEqual(eval(r""" BR'\x01' """), b'\\' + b'x01') | ||
| self.assertEqual(eval(""" F'{1+1}' """), '2') | ||
| self.assertEqual(eval(""" U'\U0001d120' """), '\U0001d120') |
There was a problem hiding this comment.
Presumably the lowercase versions are covered by other tests (right?)
Would it be simpler here to just assert in each case that the lowercase and upper case prefixes generate the same thing? For instance, self.assertEqual(eval(""" F'{1+1}' """), eval(""" f'{1+1}' """)).
There was a problem hiding this comment.
That's a good idea. Updated.
|
IIUC this is covering the uppercase cases here: http://droettboom.com/cpython-coverage/llvm-coverage/coverage/home/mdboom/Work/builds/cpython/Parser/string_parser.c.html#L183 |
Lib/test/test_string_literals.py
Outdated
| self.assertEqual(eval(r""" R'\x01' """), r'\x01') | ||
| self.assertEqual(eval(r""" BR'\x01' """), br'\x01') | ||
| self.assertEqual(eval(""" F'{1+1}' """), f'{1+1}') | ||
| self.assertEqual(eval(""" U'\U0001d120' """), u'\U0001d120') |
There was a problem hiding this comment.
Actually do we need the eval() calls?
|
Thanks @mdboom for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
GH-97518 is a backport of this pull request to the 3.11 branch. |
…honGH-95925) (cherry picked from commit f00383e) Co-authored-by: Michael Droettboom <[email protected]>
(cherry picked from commit f00383e) Co-authored-by: Michael Droettboom <[email protected]>
|
Thanks @mdboom for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10. |
|
GH-97537 is a backport of this pull request to the 3.10 branch. |
…honGH-95925) (cherry picked from commit f00383e) Co-authored-by: Michael Droettboom <[email protected]>
(cherry picked from commit f00383e) Co-authored-by: Michael Droettboom <[email protected]>
