Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-94808: Coverage: __build_class__ inside a non-dict __builtins__ #95932

Merged
merged 1 commit into from
Aug 15, 2022
Merged

gh-94808: Coverage: __build_class__ inside a non-dict __builtins__ #95932

merged 1 commit into from
Aug 15, 2022

Conversation

mdboom
Copy link
Contributor

@mdboom mdboom commented Aug 12, 2022 •
edited by bedevere-bot
Loading

Adds coverage for this case inside the LOAD_BUILD_CLASS opcode in

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Aug 12, 2022
@mdboom mdboom mentioned this pull request Aug 12, 2022
Open
@mdboom mdboom added the needs backport to 3.11 only security fixes label Aug 12, 2022
@brandtbucher brandtbucher merged commit 3adb4d8 into python:main Aug 15, 2022
@miss-islington
Copy link
Contributor

Thanks @mdboom for the PR, and @brandtbucher for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 15, 2022
@mdboom @miss-islington
pythonGH-94808: Test __build_class__ inside non-dict __builtins__ (py…
0889e30 
…thonGH-95932)

(cherry picked from commit 3adb4d8)

Co-authored-by: Michael Droettboom <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Aug 15, 2022
@bedevere-bot
Copy link

GH-96004 is a backport of this pull request to the 3.11 branch.

pablogsal pushed a commit that referenced this pull request Sep 8, 2022
@miss-islington @mdboom
GH-94808: Test __build_class__ inside non-dict __builtins__ (GH-95932) (
0c443c2 
#96004)

(cherry picked from commit 3adb4d8)

Co-authored-by: Michael Droettboom <[email protected]>

Co-authored-by: Michael Droettboom <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandtbucher brandtbucher brandtbucher approved these changes

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mdboom @miss-islington @bedevere-bot @brandtbucher