-
-
Notifications
You must be signed in to change notification settings - Fork 30.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-96706: [doc] Fix deprecated use of get_event_loop() #96707
gh-96706: [doc] Fix deprecated use of get_event_loop() #96707
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alas, it's not so straighforward. :-(
The Hello World with call_soon() section has a label asyncio_example_lowlevel_helloworld
which is referenced from asyncio-llapi-index.rst, where it is used as an example for get_event_loop()
. So the change would make that link confusing.
(The other two are fine.)
I'm not sure what to suggest.
@gvanrossum Thank you for the review! I didn't notice that. How about we just change the link text?
|
That sounds like a good idea. Just add a commit to the PR! |
@gvanrossum I've added the commit. Thanks for the confirmation! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll merge!
Thanks @zhanpon for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
…p() in examples (pythonGH-96707) (cherry picked from commit 53a54b7) Co-authored-by: zhanpon <[email protected]>
GH-96757 is a backport of this pull request to the 3.11 branch. |
… examples (GH-96707) (cherry picked from commit 53a54b7) Co-authored-by: zhanpon <[email protected]>
… examples (GH-96707) (cherry picked from commit 53a54b7) Co-authored-by: zhanpon <[email protected]>
#96706