Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please restore the inclusion of the CHANGELOG.md in the sdist #17880

Closed
mr-c opened this issue Oct 5, 2024 · 3 comments
Closed

Please restore the inclusion of the CHANGELOG.md in the sdist #17880

mr-c opened this issue Oct 5, 2024 · 3 comments

Comments

@mr-c
Copy link
Contributor

mr-c commented Oct 5, 2024

The Debian package of mypy is built from the sdist; we also build the docs and the docs are missing the changelog due to 167dc70 from #16323

/build/mypy-1.12.0~0dev.bc8119150e49895f7a496ae7ae7362a2828e7e9e/docs/source/changelog.md:2: CRITICAL: Directive "include": file not found: '/build/mypy-1.12.0~0dev.bc8119150e49895f7a496ae7ae7362a2828e7e9e/CHANGELOG.md'
Details

/build/mypy-1.12.0~0dev.bc8119150e49895f7a496ae7ae7362a2828e7e9e/docs/source/index.rst:95: WARNING: toctree contains reference to document 'changelog' that doesn't have a title: no link will be generated
/build/mypy-1.12.0~0dev.bc8119150e49895f7a496ae7ae7362a2828e7e9e/docs/source/index.rst:95: WARNING: toctree contains reference to document 'changelog' that doesn't have a title: no link will be generated
/build/mypy-1.12.0~0dev.bc8119150e49895f7a496ae7ae7362a2828e7e9e/docs/source/index.rst:95: WARNING: toctree contains reference to document 'changelog' that doesn't have a title: no link will be generated
/build/mypy-1.12.0~0dev.bc8119150e49895f7a496ae7ae7362a2828e7e9e/docs/source/index.rst:95: WARNING: toctree contains reference to document 'changelog' that doesn't have a title: no link will be generated
/build/mypy-1.12.0~0dev.bc8119150e49895f7a496ae7ae7362a2828e7e9e/docs/source/index.rst:95: WARNING: toctree contains reference to document 'changelog' that doesn't have a title: no link will be generated
/build/mypy-1.12.0~0dev.bc8119150e49895f7a496ae7ae7362a2828e7e9e/docs/source/index.rst:95: WARNING: toctree contains reference to document 'changelog' that doesn't have a title: no link will be generated
/build/mypy-1.12.0~0dev.bc8119150e49895f7a496ae7ae7362a2828e7e9e/docs/source/index.rst:95: WARNING: toctree contains reference to document 'changelog' that doesn't have a title: no link will be generated
/build/mypy-1.12.0~0dev.bc8119150e49895f7a496ae7ae7362a2828e7e9e/docs/source/index.rst:95: WARNING: toctree contains reference to document 'changelog' that doesn't have a title: no link will be generated
/build/mypy-1.12.0~0dev.bc8119150e49895f7a496ae7ae7362a2828e7e9e/docs/source/index.rst:95: WARNING: toctree contains reference to document 'changelog' that doesn't have a title: no link will be generated
/build/mypy-1.12.0~0dev.bc8119150e49895f7a496ae7ae7362a2828e7e9e/docs/source/index.rst:95: WARNING: toctree contains reference to document 'changelog' that doesn't have a title: no link will be generated
/build/mypy-1.12.0~0dev.bc8119150e49895f7a496ae7ae7362a2828e7e9e/docs/source/index.rst:95: WARNING: toctree contains reference to document 'changelog' that doesn't have a title: no link will be generated
/build/mypy-1.12.0~0dev.bc8119150e49895f7a496ae7ae7362a2828e7e9e/docs/source/index.rst:95: WARNING: toctree contains reference to document 'changelog' that doesn't have a title: no link will be generated
/build/mypy-1.12.0~0dev.bc8119150e49895f7a496ae7ae7362a2828e7e9e/docs/source/index.rst:95: WARNING: toctree contains reference to document 'changelog' that doesn't have a title: no link will be generated
/build/mypy-1.12.0~0dev.bc8119150e49895f7a496ae7ae7362a2828e7e9e/docs/source/index.rst:95: WARNING: toctree contains reference to document 'changelog' that doesn't have a title: no link will be generated
/build/mypy-1.12.0~0dev.bc8119150e49895f7a496ae7ae7362a2828e7e9e/docs/source/index.rst:95: WARNING: toctree contains reference to document 'changelog' that doesn't have a title: no link will be generated
/build/mypy-1.12.0~0dev.bc8119150e49895f7a496ae7ae7362a2828e7e9e/docs/source/index.rst:95: WARNING: toctree contains reference to document 'changelog' that doesn't have a title: no link will be generated
/build/mypy-1.12.0~0dev.bc8119150e49895f7a496ae7ae7362a2828e7e9e/docs/source/index.rst:95: WARNING: toctree contains reference to document 'changelog' that doesn't have a title: no link will be generated
/build/mypy-1.12.0~0dev.bc8119150e49895f7a496ae7ae7362a2828e7e9e/docs/source/index.rst:95: WARNING: toctree contains reference to document 'changelog' that doesn't have a title: no link will be generated
/build/mypy-1.12.0~0dev.bc8119150e49895f7a496ae7ae7362a2828e7e9e/docs/source/index.rst:95: WARNING: toctree contains reference to document 'changelog' that doesn't have a title: no link will be generated
/build/mypy-1.12.0~0dev.bc8119150e49895f7a496ae7ae7362a2828e7e9e/docs/source/index.rst:95: WARNING: toctree contains reference to document 'changelog' that doesn't have a title: no link will be generated
/build/mypy-1.12.0~0dev.bc8119150e49895f7a496ae7ae7362a2828e7e9e/docs/source/index.rst:95: WARNING: toctree contains reference to document 'changelog' that doesn't have a title: no link will be generated
/build/mypy-1.12.0~0dev.bc8119150e49895f7a496ae7ae7362a2828e7e9e/docs/source/index.rst:95: WARNING: toctree contains reference to document 'changelog' that doesn't have a title: no link will be generated
/build/mypy-1.12.0~0dev.bc8119150e49895f7a496ae7ae7362a2828e7e9e/docs/source/index.rst:95: WARNING: toctree contains reference to document 'changelog' that doesn't have a title: no link will be generated
/build/mypy-1.12.0~0dev.bc8119150e49895f7a496ae7ae7362a2828e7e9e/docs/source/index.rst:95: WARNING: toctree contains reference to document 'changelog' that doesn't have a title: no link will be generated
/build/mypy-1.12.0~0dev.bc8119150e49895f7a496ae7ae7362a2828e7e9e/docs/source/index.rst:95: WARNING: toctree contains reference to document 'changelog' that doesn't have a title: no link will be generated
/build/mypy-1.12.0~0dev.bc8119150e49895f7a496ae7ae7362a2828e7e9e/docs/source/index.rst:95: WARNING: toctree contains reference to document 'changelog' that doesn't have a title: no link will be generated
/build/mypy-1.12.0~0dev.bc8119150e49895f7a496ae7ae7362a2828e7e9e/docs/source/index.rst:95: WARNING: toctree contains reference to document 'changelog' that doesn't have a title: no link will be generated
/build/mypy-1.12.0~0dev.bc8119150e49895f7a496ae7ae7362a2828e7e9e/docs/source/index.rst:95: WARNING: toctree contains reference to document 'changelog' that doesn't have a title: no link will be generated
/build/mypy-1.12.0~0dev.bc8119150e49895f7a496ae7ae7362a2828e7e9e/docs/source/index.rst:95: WARNING: toctree contains reference to document 'changelog' that doesn't have a title: no link will be generated
/build/mypy-1.12.0~0dev.bc8119150e49895f7a496ae7ae7362a2828e7e9e/docs/source/index.rst:95: WARNING: toctree contains reference to document 'changelog' that doesn't have a title: no link will be generated
/build/mypy-1.12.0~0dev.bc8119150e49895f7a496ae7ae7362a2828e7e9e/docs/source/index.rst:95: WARNING: toctree contains reference to document 'changelog' that doesn't have a title: no link will be generated
/build/mypy-1.12.0~0dev.bc8119150e49895f7a496ae7ae7362a2828e7e9e/docs/source/index.rst:95: WARNING: toctree contains reference to document 'changelog' that doesn't have a title: no link will be generated
/build/mypy-1.12.0~0dev.bc8119150e49895f7a496ae7ae7362a2828e7e9e/docs/source/index.rst:95: WARNING: toctree contains reference to document 'changelog' that doesn't have a title: no link will be generated
/build/mypy-1.12.0~0dev.bc8119150e49895f7a496ae7ae7362a2828e7e9e/docs/source/index.rst:95: WARNING: toctree contains reference to document 'changelog' that doesn't have a title: no link will be generated
/build/mypy-1.12.0~0dev.bc8119150e49895f7a496ae7ae7362a2828e7e9e/docs/source/index.rst:95: WARNING: toctree contains reference to document 'changelog' that doesn't have a title: no link will be generated
/build/mypy-1.12.0~0dev.bc8119150e49895f7a496ae7ae7362a2828e7e9e/docs/source/index.rst:95: WARNING: toctree contains reference to document 'changelog' that doesn't have a title: no link will be generated
/build/mypy-1.12.0~0dev.bc8119150e49895f7a496ae7ae7362a2828e7e9e/docs/source/index.rst:95: WARNING: toctree contains reference to document 'changelog' that doesn't have a title: no link will be generated
/build/mypy-1.12.0~0dev.bc8119150e49895f7a496ae7ae7362a2828e7e9e/docs/source/index.rst:95: WARNING: toctree contains reference to document 'changelog' that doesn't have a title: no link will be generated
generating indices... genindex /build/mypy-1.12.0~0dev.bc8119150e49895f7a496ae7ae7362a2828e7e9e/docs/source/index.rst:95: WARNING: toctree contains reference to document 'changelog' that doesn't have a title: no link will be generated
done
writing additional pages... search /build/mypy-1.12.0~0dev.bc8119150e49895f7a496ae7ae7362a2828e7e9e/docs/source/index.rst:95: WARNING: toctree contains reference to document 'changelog' that doesn't have a title: no link will be generated

Is that workaround still needed? Can 167dc70 be reverted?

@hauntsaninja
Copy link
Collaborator

Naive revert won't work, will need an explicit include (we'll want to keep the check-manifest step in the wheel builds repo happy)

@ilevkivskyi
Copy link
Member

IIUC this should now be fixed by #17882, please feel free to re-open if it didn't work (this missed the cut-off for coming release, but should be available in the next one).

@mr-c
Copy link
Contributor Author

mr-c commented Oct 6, 2024

Thank you @ilevkivskyi !

JukkaL pushed a commit that referenced this issue Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants