Fix Generic with ParamSpec not subscriptable with multiple arguments [non-generic-variant] #491
Conversation
|
Note changes here are the combined checks from |
| # we do not check the count | ||
| if (inspect.isclass(cls) and issubclass(cls, typing.Generic) | ||
| and len(cls.__parameters__) == 1 | ||
| and isinstance(cls.__parameters__[0], ParamSpec) |
There was a problem hiding this comment.
Do we need to check both typing.ParamSpec and typing_extensions.ParamSpec?
There was a problem hiding this comment.
I do not think so. For 3.10 the _TypeVarLikeMeta __instancecheck__ of typing_extensions.ParamSpec will check for the typing variant. And as typing_extensions.ParamSpec.__new__ creates a typing.ParamSpec everything should be covered.
There was a problem hiding this comment.
I think it might be useful to have a test on 3.10+ that uses typing.Concatenate and typing.ParamSpec, which are different from the typing_extensions version.
There was a problem hiding this comment.
Tests added & like noted in #489 for Concatenate a patch was necessary.
This PR assures that no TypeError is raised, however there are still multiple limitations for Python <3.11.3
I think some of the 3.10 cases could be a regression; I am still looking into that and will create a separate issue. #489 will fix most of the cases as a follow up of this PR.