Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add contributing guidelines for third party and custom C++ operators #1742

Merged
merged 4 commits into from
Jun 1, 2022
Merged

Add contributing guidelines for third party and custom C++ operators #1742

merged 4 commits into from
Jun 1, 2022

Conversation

Nayef211
Copy link
Contributor

Summary

  • Updating contribution guidelines to add sections for adding third party libraries and custom C++ ops

@Nayef211 Nayef211 requested review from parmeet and mthrok May 25, 2022 22:41
mthrok
mthrok reviewed May 25, 2022
View reviewed changes
CONTRIBUTING.md Outdated
[`​​LIBTORCHTEXT_INCLUDE_DIRS`](https://github.com/pytorch/text/blob/70fc1040ee40faf129604557107cc59fd51c4fe2/torchtext/csrc/CMakeLists.txt#L24)
and to
[`EXTENSION_INCLUDE_DIRS`](https://github.com/pytorch/text/blob/70fc1040ee40faf129604557107cc59fd51c4fe2/torchtext/csrc/CMakeLists.txt#L119)
- Add the submodule name to
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, its "target" names, defined by the third party CMakeLists.

https://cmake.org/cmake/help/latest/manual/cmake-buildsystem.7.html#introduction

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
Nayef211
Nayef211 commented May 26, 2022
View reviewed changes
Copy link
Contributor Author

@Nayef211 Nayef211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback @mthrok. Just addressed most of your comments. Lmk if you have any other suggestions before merging this :)

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated
[`​​LIBTORCHTEXT_INCLUDE_DIRS`](https://github.com/pytorch/text/blob/70fc1040ee40faf129604557107cc59fd51c4fe2/torchtext/csrc/CMakeLists.txt#L24)
and to
[`EXTENSION_INCLUDE_DIRS`](https://github.com/pytorch/text/blob/70fc1040ee40faf129604557107cc59fd51c4fe2/torchtext/csrc/CMakeLists.txt#L119)
- Add the submodule name to
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
@Nayef211 Nayef211 marked this pull request as ready for review May 26, 2022 18:44
@Nayef211 Nayef211 requested a review from mthrok May 26, 2022 18:44
@Nayef211 Nayef211 merged commit cb8475e into pytorch:main Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mthrok mthrok mthrok approved these changes

@parmeet parmeet Awaiting requested review from parmeet

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nayef211 @mthrok @facebook-github-bot