Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added post install script for pywin32 #1748

Merged
merged 7 commits into from
Jun 1, 2022

Conversation

Nayef211
Copy link
Contributor

@Nayef211 Nayef211 commented May 26, 2022

Description

Resolving Windows test failures related to portalocker by following suggestions in pytorch/data#441 (comment)

@Nayef211 Nayef211 marked this pull request as ready for review June 1, 2022 18:31
@Nayef211 Nayef211 requested a review from parmeet June 1, 2022 18:31
@Nayef211 Nayef211 changed the title [WIP] Added post install script for pywin32 Added post install script for pywin32 Jun 1, 2022
Copy link
Contributor

@parmeet parmeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Nayef211 for the fix. Could you please rebase branch on main, seems like test failures are related to previous issues in datasets directory.

@Nayef211
Copy link
Contributor Author

Nayef211 commented Jun 1, 2022

All windows failures are not related to pywin32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants