Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put pytestmark at top of file #8032

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Conversation

NicolasHug
Copy link
Member

@NicolasHug NicolasHug commented Oct 9, 2023

Right now it's hidden in the middle of the file and it's hard to find

cc @vfdev-5 @pmeier

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 9, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8032

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 New Failures, 13 Unrelated Failures

As of commit f42d9c5 with merge base 1101c3d (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @NicolasHug

@NicolasHug NicolasHug merged commit 347f942 into pytorch:main Oct 9, 2023
42 of 62 checks passed
@github-actions
Copy link

github-actions bot commented Oct 9, 2023

Hey @NicolasHug!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

facebook-github-bot pushed a commit that referenced this pull request Oct 31, 2023
Reviewed By: vmoens

Differential Revision: D50789098

fbshipit-source-id: 46cf78e6a5b6a29f7f16838ae5f7aefc18f7601d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants