Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid segfault in VideoClip test #8148

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Avoid segfault in VideoClip test #8148

merged 1 commit into from
Dec 5, 2023

Conversation

NicolasHug
Copy link
Member

@NicolasHug NicolasHug commented Dec 5, 2023 •
edited by pytorch-bot bot
Loading

Closes #8147

I couldn't trace the problem back to a change in the DataLoader from torch core.

Considering:

  • this popped randomly (without an obvious upstream change)
  • this only happens on 3.8
  • this only happens when num_workers > 0
  • num_workers>0 works fine in test_video_clips()

If there's an actual legit issue/bug somewhere, it's unlikely that it comes directly from torchvision. I'm just going to set num_workers=0 here to silence the issue.

cc @pmeier

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Dec 5, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8148

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit 271108e with merge base 30397d9 (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@NicolasHug
Copy link
Member Author

https://github.com/pytorch/vision/actions/runs/7100674099/job/19327246621?pr=8148 is back to green

pmeier
pmeier approved these changes Dec 5, 2023
View reviewed changes
Copy link
Collaborator

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@NicolasHug NicolasHug merged commit fe0d280 into pytorch:main Dec 5, 2023
62 of 64 checks passed
@NicolasHug NicolasHug deleted the aefjnaelfjnalefjn branch December 5, 2023 13:16
facebook-github-bot pushed a commit that referenced this pull request Jan 16, 2024
@NicolasHug @facebook-github-bot
[fbsync] Avoid segfault in VideoClip test (#8148)
e59dc0f 
Reviewed By: vmoens

Differential Revision: D52538996

fbshipit-source-id: cc4fa314a1b12390b9b4c5094d35fa942ef79147
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmeier pmeier pmeier approved these changes

Assignees
No one assigned
Labels
cla signed enhancement module: tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Segfault in VideoClip test on python 3.8
3 participants
@NicolasHug @pmeier @facebook-github-bot