Allow SanitizeBoundingBoxes to sanitize more labels #8319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8319
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit c9bd6c8 with merge base 53869eb ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
NicolasHug
commented
Mar 15, 2024
pmeier
approved these changes
Mar 15, 2024
| labels = tuple(labels) | ||
| for entry in labels: | ||
| if not isinstance(entry, torch.Tensor): | ||
| # TODO: we don't need to enforce tensors, just that entries are indexable as t[bool_mask] |
There was a problem hiding this comment.
Just checking: was this a requirement from the issue or a nice to have?
|
Thanks ! :) |
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 21, 2024
Reviewed By: vmoens Differential Revision: D55062811 fbshipit-source-id: 2216cc6805bff1c69d3dd7e570b80c927b82d19a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8294
We allow the
labels_getterparameter ofSanitizeBoudingBoxesto return a tuple. Each entry in the tuple gets sanitized/subsampled, along with the boxes. This enables the sanitization of properties like "area" or "iscrowd" from COCO.cc @vfdev-5