Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FBcode -> GH] Fix fetch_png_exif_orientation #8345

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

NicolasHug
Copy link
Member

@NicolasHug NicolasHug commented Mar 20, 2024

This function is failing the internal CI because it's not always retuning an int.

sion/torchvision/csrc/io/image/cpu/exif.h:218:1: error: non-void function does not return a value in all control paths [-Werror,-Wreturn-type]

Note for self: I fixed the issue in the original diff D55062769, so I'm just adding [FBCode -> GH] in this PR so that it doesn't get synced back to fbcode.

@NicolasHug NicolasHug requested a review from vfdev-5 March 20, 2024 11:30
Copy link

pytorch-bot bot commented Mar 20, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8345

Note: Links to docs will display an error until the docs builds have been completed.

❌ 16 New Failures, 20 Unrelated Failures

As of commit fb5154b with merge base a0c79b3 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks to your internal code linter!

@NicolasHug NicolasHug merged commit 2c4665f into pytorch:main Mar 26, 2024
2 of 9 checks passed
@NicolasHug NicolasHug deleted the alefjnalfjenaef branch March 26, 2024 12:31
NicolasHug added a commit to NicolasHug/vision that referenced this pull request Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants