Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused dynamo import #8451

Merged
merged 3 commits into from
Jun 7, 2024
Merged

Conversation

NicolasHug
Copy link
Member

@NicolasHug NicolasHug commented May 29, 2024

Following up on my confusion from #8436 (comment), @ezyang can you confirm that prior to this PR we weren't taking advantage of the "lazy import"? (Otherwise, I still don't get the point of lazy_compile)

Copy link

pytorch-bot bot commented May 29, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8451

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 3 New Failures, 2 Unrelated Failures

As of commit f4bf776 with merge base 375cfdf (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@ezyang
Copy link
Contributor

ezyang commented May 29, 2024

looks like it works

@NicolasHug NicolasHug merged commit b09b3f6 into pytorch:main Jun 7, 2024
68 of 73 checks passed
@NicolasHug NicolasHug deleted the leanfljaenflajenf branch June 7, 2024 11:33
facebook-github-bot pushed a commit that referenced this pull request Aug 2, 2024
Reviewed By: vmoens

Differential Revision: D60596224

fbshipit-source-id: f74db31da7c828b0d37f200b1f381c5dc9d72144
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants