Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pyyaml < 4 for CVE-2017-18342 #2271

Closed
alex opened this issue Jun 27, 2018 · 10 comments
Closed

Add pyyaml < 4 for CVE-2017-18342 #2271

alex opened this issue Jun 27, 2018 · 10 comments

Comments

@alex
Copy link

alex commented Jun 27, 2018

The default insecurity of yaml.load has been assigned CVE-2017-18342. This is resolved in PyYAML >= 4

@alefhsousa
Copy link

Hey @alex I checked the official website https://pyyaml.org/wiki/PyYAML, in the site the current version is 3.13. The pyup is broken my PR because for him exists a vulnerability in this version of the library. I think this pr is referencing the library: https://pypi.org/project/pyaml/#history is right?

@alex
Copy link
Author

alex commented Jul 17, 2018 via email

@Jwomers
Copy link
Member

Jwomers commented Jul 17, 2018

@alex @alefhsousa Justin from PyUp here. We are monitoring this. It looks like PyYAML version 4.1 exists in their repository (see https://github.com/yaml/pyyaml/blob/master/setup.py ), but has not been published to PyPi ( https://pypi.org/project/PyYAML/ )

@alex
Copy link
Author

alex commented Jul 17, 2018 via email

@Jwomers
Copy link
Member

Jwomers commented Jul 17, 2018

@alex got it. Looking through their releases, it looks like 3.13 might actually fix the issue. I have opened an issue on PyYAML GitHub to ask for clarification.

@Jwomers
Copy link
Member

Jwomers commented Jul 20, 2018

Update here, 3.13 does not fix the issue, read more here - they are advising that 4.2 (next release) has high hopes of fixing the issue. The vulnerability is now in the PyUp proprietary safety database and will get added to safety-db in the next monthly update. So no fix for now :(

@acaprari
Copy link

Hi, unfortunately PyYAML is a dependency of many libraries (awscli and moto just to mention some) and as such it gets included implicitly in many projects. Also, the fix for the CVE hasn't reached consensum yet (see yaml/pyyaml#189) and it's not known whether the next 4.2 release would include it.

For the build of our components we had to choose between disabling dependency checks as a whole or having all the builds failing.

I understand this is an unfortunate situation, but what's the best solution for this kind of thing? Is it possible to have the CVE advisory ignored and excluded from the safety DB until an actual fix gets released?

@Jwomers
Copy link
Member

Jwomers commented Jul 23, 2018

@acaprari Great question, we are debating this internally. We should have an answer today, likely we'll remove the advisory from Safety DB for the time being.

@timofurrer
Copy link

@acaprari Great question, we are debating this internally. We should have an answer today, likely we'll remove the advisory from Safety DB for the time being.

@Jwomers did you come to any conclusions? Seems like it's still treated as vulnerability?

@Jwomers
Copy link
Member

Jwomers commented Aug 2, 2018

@timofurrer we've removed this is an advisory for now since there is no fix.

@Jwomers Jwomers closed this as completed Aug 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants