New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why xlsx.RemoveRow("Sheet1", 2) removes 3rd row not second? #349

Closed

albenik opened this issue Mar 6, 2019 · 1 comment

Contributor

albenik commented Mar 6, 2019

As described in https://github.com/360EntSecGroup-Skylar/excelize/blob/master/rows.go#L341

// RemoveRow provides a function to remove single row by given worksheet name
// and row index. For example, remove row 3 in Sheet1:
//
// xlsx.RemoveRow("Sheet1", 2)

Contributor Author

albenik commented Mar 6, 2019 •

edited

Loading

Ok, answer myself.
Because row argument probably is not Excel row number, but zero-based slice row number.

Counter-intuitive as for me :(

albenik mentioned this issue

Implement consistent row addressing by Excel row number starting with 1 #350

Merged

10 tasks

albenik closed this as completed

albenik mentioned this issue

Huge refactorig for consistent col/row numbering #356

Merged

10 tasks

xuri mentioned this issue

PR 366 Documentation #360

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment