-
-
Notifications
You must be signed in to change notification settings - Fork 39.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Umbra support to QMK #24569
base: master
Are you sure you want to change the base?
Umbra support to QMK #24569
Conversation
Adding IV Works Umbra to QMK.
I am not sure why the checks have failed. I was advised to make a clean fork and try the pull again but having the same issues. When I submitted with each version of the PCB (hotswap and solder) in there own files - not sharing the config.h and rules.mk the checks passed. Any help would be much appreciated. |
Deleting to reupload the previous folder structure.
Adding support for IV Works Umbra.
I moved the config.h and rules.mk files to each subfolder and the checks passed. |
Please refrain from closing/opening new PRs for the same content.
I cant see that request anywhere. To provide updates, such as to requested changes, please just push additional commits to the same branch used for this PR. |
Understood. Sorry about that, this is my first time submitting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bottom row options standard
and 6U bottom row
are identical, could that be rectified?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch! Updated.
Corrected 6u bottom row.
Co-authored-by: Duncan Sutherland <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the review! I believe I reviewed and committed all suggestions.
Description
Adding IV Works Umbra to QMK.
Types of Changes
Issues Fixed or Closed by This PR
Checklist