Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Umbra support to QMK #24569

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

josephawilliamsiv
Copy link

@josephawilliamsiv josephawilliamsiv commented Nov 6, 2024

Description

Adding IV Works Umbra to QMK.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Adding IV Works Umbra to QMK.
@josephawilliamsiv
Copy link
Author

I am not sure why the checks have failed. I was advised to make a clean fork and try the pull again but having the same issues.

When I submitted with each version of the PCB (hotswap and solder) in there own files - not sharing the config.h and rules.mk the checks passed.

Any help would be much appreciated.

Deleting to reupload the previous folder structure.
Adding support for IV Works Umbra.
@josephawilliamsiv
Copy link
Author

I moved the config.h and rules.mk files to each subfolder and the checks passed.

@zvecr
Copy link
Member

zvecr commented Nov 6, 2024

Please refrain from closing/opening new PRs for the same content.

I was advised to make a clean fork and try the pull again

I cant see that request anywhere.

To provide updates, such as to requested changes, please just push additional commits to the same branch used for this PR.

@josephawilliamsiv
Copy link
Author

Understood. Sorry about that, this is my first time submitting.

keyboards/umbra/hotswap/keyboard.json Outdated Show resolved Hide resolved
keyboards/umbra/hotswap/keyboard.json Outdated Show resolved Hide resolved
keyboards/umbra/hotswap/keyboard.json Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bottom row options standard and 6U bottom row are identical, could that be rectified?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! Updated.

keyboards/umbra/solder/matrix_diagram.md Outdated Show resolved Hide resolved
keyboards/umbra/solder/keyboard.json Outdated Show resolved Hide resolved
keyboards/umbra/solder/keyboard.json Outdated Show resolved Hide resolved
keyboards/umbra/solder/keyboard.json Show resolved Hide resolved
keyboards/umbra/solder/keyboard.json Outdated Show resolved Hide resolved
keyboards/umbra/solder/keyboard.json Show resolved Hide resolved
josephawilliamsiv and others added 2 commits November 13, 2024 10:34
Corrected 6u bottom row.
Co-authored-by: Duncan Sutherland <[email protected]>
Copy link
Author

@josephawilliamsiv josephawilliamsiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the review! I believe I reviewed and committed all suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants