Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add keyboard suika27melo #24616

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

add keyboard suika27melo #24616

wants to merge 6 commits into from
+137 −0

Conversation

suikagiken
Copy link
Contributor

@suikagiken suikagiken commented Nov 19, 2024 •
edited
Loading

Description

Add keyboard suikagiken/suika27melo.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • n/a

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

waffle87
waffle87 reviewed Nov 19, 2024
View reviewed changes
keyboards/suikagiken/suika27melo/keyboard.json Outdated Show resolved Hide resolved
keyboards/suikagiken/suika27melo/keyboard.json Outdated Show resolved Hide resolved
keyboards/suikagiken/suika27melo/readme.md Outdated Show resolved Hide resolved
keyboards/suikagiken/suika27melo/readme.md Outdated Show resolved Hide resolved
keyboards/suikagiken/suika27melo/readme.md Outdated Show resolved Hide resolved
suikagiken
suikagiken commented Nov 19, 2024
View reviewed changes
Copy link
Contributor Author

@suikagiken suikagiken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@waffle87 Thank you for your suggestion.
I have made the corrections.

@suikagiken suikagiken marked this pull request as ready for review November 19, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waffle87 waffle87 waffle87 approved these changes

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@suikagiken @waffle87