Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automerge bot improvements: tests and paging #4310

Open
balopat opened this issue Jul 9, 2021 · 0 comments
Open

Automerge bot improvements: tests and paging #4310

balopat opened this issue Jul 9, 2021 · 0 comments
Labels
area/cirqbot kind/health For CI/testing/release process/refactoring/technical debt items

Comments

@balopat
Copy link
Contributor

balopat commented Jul 9, 2021

Description of the issue

There are a bunch of Github queries in dev_tools/auto_merge.py that are supposed to be paged - they haven't been failing as the PRs themselves are typically small, but weird behavior happens when the number of records is larger than the per_page number. We introduced a while ago get_all which does the paging automatically, we should introduce that to all of the queries.

Also, we should introduce testing against a fake Github API service implementation. There are precisely 0 tests written for it at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cirqbot kind/health For CI/testing/release process/refactoring/technical debt items
Projects
Status: No status
Development

No branches or pull requests

4 participants