Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix search in Readthedocs configuration with workaround #264

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

EwoutH
Copy link
Collaborator

@EwoutH EwoutH commented Apr 24, 2023

This commit fixes search by adding a workaround to the Readthedocs configuration in conf.py.

For the workaround see readthedocs/sphinx_rtd_theme#1452 (comment)

For the upstream issue see readthedocs/readthedocs.org#10263.

All other Readthedocs changes will come in a separate PR, so this can be merged with the least resistance.

This commit fixes search by adding a workaround to the Readthedocs configuration.

For the workaround see readthedocs/sphinx_rtd_theme#1452 (comment)
@EwoutH EwoutH requested a review from quaquel April 24, 2023 17:56
@quaquel quaquel merged commit 1a3c678 into master Apr 24, 2023
@EwoutH
Copy link
Collaborator Author

EwoutH commented Apr 24, 2023

Validated, search is working again! Great timing for the course!

I will look tomorrow at search ranking.

Thanks @stsewd for the swift support!

@quaquel
Copy link
Owner

quaquel commented Apr 24, 2023

Great that this ahs been fixed and indeed thanks @stsewd for the quick reply.

EwoutH added a commit that referenced this pull request Jun 18, 2023
This commit fixes search by adding a workaround to the Readthedocs configuration.

For the workaround see readthedocs/sphinx_rtd_theme#1452 (comment)
@quaquel quaquel deleted the readthedocs-fix-search branch November 18, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants