-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate Mutiny wrapper for Async Clients #998
Comments
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
@scrocquesel I would like to contribute here. I have a question. Do you think it would be good idea, to not only change type from CompletionStage to Uni but also handle context switching? This would (to my understanding) fix those 2 issues |
We don't have control on the signature of the amazon async client. |
Context switching is another beast I don't know how to tackle. The issue is that we could have interceptor that will be call by the AWS SDK. I guess we would need to find a way to force the AWS SDK to continue on a context aware thread or capture/restore the thread context. Otherwise, having it handled in the mutiny wrapper at a slightly higher level would be a good start and fill 90% user use cases. |
I was aiming to provide at least helper method that will handle sth like
to get both Uni type and context switch |
@scrocquesel |
It would be great to have some Mutiny wrappers for AWS Async Client that return some
Uni
instead ofCompletionStage
.There is already that for Vert.x:
io.vertx.mutiny.core.eventbus.EventBus
is a wrapper forio.vertx.core.eventbus.EventBus
That would avoid us to write things like (in Kotlin):
The text was updated successfully, but these errors were encountered: