Remove operation id prefix #865
Open
+29
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bohotmail/quarkus-openapi-generator into remove-operation-id-prefix
fjtirado
approved these changes
Nov 22, 2024
ricardozanini
requested changes
Nov 22, 2024
There was a problem hiding this comment.
I need help finding what this PR is doing. I'm only seeing an introduction of a property to the generator. What do you do with it after? Or is this something that the underlying generator already takes care of? If so, please add a reference.
Can you also please add some tests under the integration-tests module?
| import static io.quarkiverse.openapi.generator.deployment.CodegenConfig.ConfigName.MODEL_NAME_SUFFIX; | ||
| import static io.quarkiverse.openapi.generator.deployment.CodegenConfig.ConfigName.TEMPLATE_BASE_DIR; | ||
| import static io.quarkiverse.openapi.generator.deployment.CodegenConfig.ConfigName.VALIDATE_SPEC; | ||
| import static io.quarkiverse.openapi.generator.deployment.CodegenConfig.ConfigName.*; |
There was a problem hiding this comment.
Please don't use star imports.
| @@ -88,6 +88,13 @@ quarkus.openapi-generator.codegen.spec.petstore_json.model-name-suffix=CustomMod | |||
| quarkus.openapi-generator.codegen.spec.petstore_json.model-name-prefix=CustomModelPrefix | |||
| ---- | |||
|
|
|||
| You can customize the name of generated method. To do that, you must define the following properties: | |||
There was a problem hiding this comment.
Suggested change
| You can customize the name of generated method. To do that, you must define the following properties: | |
| You can customize the name of the generated method. To do that, you must define the following properties: |
Can you please elaborate a bit more this doc?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many thanks for submitting your Pull Request ❤️!
Please make sure that your PR meets the following requirements:
[0.9.x] SubjectFix #866
When use smallrye openapi operationid strategy CLASS_METHOD,operationId fields take the form of "class_name_method". For example, "User_findAll".
In this PR, we add a config properties remove-operation-id-prefix,to delete class name from operationId.