Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assorted fixes for management interface #44648

Merged
merged 4 commits into from
Nov 26, 2024
Merged

Assorted fixes for management interface #44648

merged 4 commits into from
Nov 26, 2024

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Nov 22, 2024

Fixes #44643 among other things.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 22, 2024 •
edited
Loading

🙈 The PR is closed and the preview is expired.

@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@gsmet gsmet force-pushed the fix-management-interface-defaults branch from 451f232 to 3815a6a Compare November 23, 2024 15:22
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
cescoffier
cescoffier requested changes Nov 25, 2024
View reviewed changes
Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The failing tests are related. There are a few more places when 0.0.0.0 needs to be replaced by localhost.

@gsmet
Copy link
Member Author

gsmet commented Nov 25, 2024

Yeah, I thought I could avoid a big search but I will do that now (and obviously, there will be only one left...).

@gsmet
Default Management interface to localhost in dev and test mode
25c8415 
It used to be 0.0.0.0, which was clearly documented and advertised, but
a bit unsafe so let's make sure it's consistent with what we do for the
main HTTP interface.
@gsmet
Adjust the default of NonApplicationRootPathBuildItem
d5026a8 
We will always have the config defined except in some weird cases. Let's
make sure we use the safest default in these cases.
@gsmet
Take into account TLS registry config for generating URLs
b8a7127
@gsmet
Improve TLS config doc for management interface
884b651
@gsmet gsmet force-pushed the fix-management-interface-defaults branch from 3815a6a to 884b651 Compare November 25, 2024 15:46
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Nov 25, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 884b651.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

@cescoffier cescoffier added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Nov 25, 2024
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Nov 25, 2024 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 884b651.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@cescoffier cescoffier merged commit 2a45367 into quarkusio:main Nov 26, 2024
55 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Nov 26, 2024
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cescoffier cescoffier cescoffier approved these changes

Assignees
No one assigned
Labels
area/documentation area/health area/metrics area/oidc area/smallrye area/vertx
Projects
None yet
Milestone
3.18 - main
Development

Successfully merging this pull request may close these issues.

Management interface - TLS detection apparently doesn't check TLS registry config
2 participants
@gsmet @cescoffier