Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chapter iteration benchmark #694

Closed
WaDelma opened this issue Aug 23, 2023 · 2 comments
Closed

Chapter iteration benchmark #694

WaDelma opened this issue Aug 23, 2023 · 2 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed Waiting for PR

Comments

@WaDelma
Copy link

WaDelma commented Aug 23, 2023

Currently the benchmark shown there doesn't assign the return value of Repeat anywhere. This means that it could get optimized away and we'd get useless benchmark results.

There should be at least warning about this or the example should be modified so that such optimization cannot happen. Here is an example how this can apparently be done.

@quii
Copy link
Owner

quii commented Jun 21, 2024

Today I learned! It would be good if someone could add a note about this

@deining
Copy link
Contributor

deining commented Nov 22, 2024

With PR #781 merged, this issue should be closed.

@quii quii closed this as completed Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed Waiting for PR
Projects
None yet
Development

No branches or pull requests

3 participants