Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a bugfix release of quinn-udp #1532

Closed
link2xt opened this issue Apr 12, 2023 · 9 comments
Closed

Make a bugfix release of quinn-udp #1532

link2xt opened this issue Apr 12, 2023 · 9 comments

Comments

@link2xt
Copy link
Contributor

link2xt commented Apr 12, 2023

The latest release 0.3.2 does not include #1516 and because of this deltachat-core-rust is stuck patching the dependency:
https://github.com/deltachat/deltachat-core-rust/blob/cecc080931f7915dee968ab18e09c625fd2ebbe4/Cargo.toml#L28

@Ralith
Copy link
Collaborator

Ralith commented Apr 14, 2023

Thanks for reaching out! I don't think there's anything big to wait for here, but let's get in #1533 in first to avoid future breakage.

@djc
Copy link
Member

djc commented Apr 14, 2023

@link2xt if you submit a PR to bump the version number, I'll publish it soon after.

@link2xt
Copy link
Contributor Author

link2xt commented Apr 14, 2023

I made a PR: #1535

Note that it depends on quinn-proto 0.10 which should be published too, the version is already bumped there but it was never tagged.

@djc
Copy link
Member

djc commented Apr 14, 2023

Ahh, sorry, forgot that -udp depends on -proto. Conceptually it maybe shouldn't...

I guess we could move EcnCodepoint and Transmit over to -udp, but that would mean -proto needs to start depending on -udp, which feels not quite right? Maybe with some Cargo features to make everything except EcnCodepoint/Transmit optional?

I don't like the idea of adding another crate just for these...

@link2xt
Copy link
Contributor Author

link2xt commented Apr 14, 2023

I really don't like "features" and try to avoid conditional compilation whenever possible. While "more crates" sounds good to me, because when things are in separate crates it means there are no unexpected dependencies between modules.

But is there something preventing release of quinn-proto? The version is already bumped there, isn't 0.10 supposed to be published?

@djc
Copy link
Member

djc commented Apr 14, 2023

Nope, it wasn't published yet -- we proactively bumped the version when we made a semver-incompatible API change.

See #1528 for release planning.

@Ralith
Copy link
Collaborator

Ralith commented Apr 14, 2023

I don't like the idea of adding another crate just for these...

I think the practical (if mildly tedious) solution is for -udp and -proto to provide independent but broadly identical definitions of these types, with quinn proper converting as needed.

@djc
Copy link
Member

djc commented Apr 19, 2023

I think this will have to effectively become part of #1528.

@djc
Copy link
Member

djc commented May 10, 2023

Going to close this, will release 0.4 as part of #1528.

@djc djc closed this as not planned Won't fix, can't repro, duplicate, stale May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants