-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make a bugfix release of quinn-udp #1532
Comments
Thanks for reaching out! I don't think there's anything big to wait for here, but let's get in #1533 in first to avoid future breakage. |
@link2xt if you submit a PR to bump the version number, I'll publish it soon after. |
I made a PR: #1535 Note that it depends on quinn-proto 0.10 which should be published too, the version is already bumped there but it was never tagged. |
Ahh, sorry, forgot that -udp depends on -proto. Conceptually it maybe shouldn't... I guess we could move I don't like the idea of adding another crate just for these... |
I really don't like "features" and try to avoid conditional compilation whenever possible. While "more crates" sounds good to me, because when things are in separate crates it means there are no unexpected dependencies between modules. But is there something preventing release of quinn-proto? The version is already bumped there, isn't 0.10 supposed to be published? |
Nope, it wasn't published yet -- we proactively bumped the version when we made a semver-incompatible API change. See #1528 for release planning. |
I think the practical (if mildly tedious) solution is for -udp and -proto to provide independent but broadly identical definitions of these types, with quinn proper converting as needed. |
I think this will have to effectively become part of #1528. |
Going to close this, will release 0.4 as part of #1528. |
The latest release 0.3.2 does not include #1516 and because of this deltachat-core-rust is stuck patching the dependency:
https://github.com/deltachat/deltachat-core-rust/blob/cecc080931f7915dee968ab18e09c625fd2ebbe4/Cargo.toml#L28
The text was updated successfully, but these errors were encountered: