PLPMTUD test fails to panic in release mode #2090
Comments
|
I guess we could gate that whole test on |
|
Option 1: Enable the panic diff --git a/quinn-proto/src/connection/mtud.rs b/quinn-proto/src/connection/mtud.rs
index be1fe7ee..6e48b5a9 100644
--- a/quinn-proto/src/connection/mtud.rs
+++ b/quinn-proto/src/connection/mtud.rs
@@ -85,7 +85,12 @@ impl MtuDiscovery {
if let Some(state) = self.state.as_mut() {
// MTUD is only active after the connection has been fully established, so it is
// guaranteed we will receive the peer's transport parameters before we start probing
- debug_assert!(matches!(state.phase, Phase::Initial));
+ if cfg!(any(debug_assertions, test)) {
+ // The test mtu_discovery_with_peer_max_udp_payload_size_after_search_panics
+ // asserts that this panics, so run the assertion even when testing in a release
+ // build
+ assert!(matches!(state.phase, Phase::Initial));
+ }
state.peer_max_udp_payload_size = peer_max_udp_payload_size;
}
}Option 2: Disable the test diff --git a/quinn-proto/src/connection/mtud.rs b/quinn-proto/src/connection/mtud.rs
index be1fe7ee..a20f15d8 100644
--- a/quinn-proto/src/connection/mtud.rs
+++ b/quinn-proto/src/connection/mtud.rs
@@ -731,6 +731,7 @@ mod tests {
assert!(completed(&mtud));
}
+ #[cfg(debug_assertions)]
#[test]
#[should_panic]
fn mtu_discovery_with_peer_max_udp_payload_size_after_search_panics() { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
On current main (73545b6), running:
cargo test --release -p quinn-proto -- connection::mtud::tests::mtu_discovery_with_peer_max_udp_payload_size_after_search_panicsGives the following failure:
This only occurs if the
--releaseflag is passed into the test run. The cause of it isquinn-proto/src/connection/mtud.rs:88being a debug assertion:Related to #1510
The text was updated successfully, but these errors were encountered: