Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put all the convert.py hooks into __init__.py? #38

Open
quantshah opened this issue Sep 30, 2022 · 1 comment
Open

Put all the convert.py hooks into __init__.py? #38

quantshah opened this issue Sep 30, 2022 · 1 comment

Comments

@quantshah
Copy link
Member

I was trying to find out where the initial hooking of qutip-tensorflow and qutip happens and it turns out that its all done in convert.py when imported in the the init.py. I feel it would be a bit more verbose to see this happen inside the init as qutip-cupy does it. That makes it very clear to see and follow the magic of how qutip-tensorflow hooks on to the data layer.

@AGaliciaMartinez what do you think? I will follow this for qutip-jax.

@AGaliciaMartinez
Copy link
Member

That sounds good! I will update it to be consistent with the other packages. thanks for letting me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants