Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support alternate signing algorithms #525

Merged
merged 2 commits into from
Nov 27, 2019
Merged

Support alternate signing algorithms #525

merged 2 commits into from
Nov 27, 2019

Conversation

akberenz
Copy link
Member

@akberenz akberenz commented Nov 27, 2019 •
edited by tresf
Loading

Support for SHA256 and SHA512 on signatures.

Drops the simplersa library in favor of calling the signature methods ourselves, as it appears to hard-code to sha1 only.

Edit: Closes #191

akberenz
akberenz commented Nov 27, 2019
View reviewed changes
js/qz-tray.js Show resolved Hide resolved
@tresf
Copy link
Contributor

tresf commented Nov 27, 2019

Bumped all signing examples to use sha512 via 49ace3d.

Note, sha512 was chosen over sha256 because it has documented performance benefits on 64-bit systems and has a stronger collision resistance over sha256. Quoting a stackoverflow answer:

Different hardware favors different functions. SHA-512 is generally faster on 64-bit processors, SHA-256 faster on 32-bit processors. (Try the command openssl speed sha256 sha512 on your computer.)

@tresf tresf mentioned this pull request Nov 27, 2019
Closed
@tresf tresf merged commit d50b0f7 into 2.1 Nov 27, 2019
@tresf tresf deleted the signing-alg branch November 27, 2019 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tresf tresf tresf left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support signature hashes other than SHA1
2 participants
@akberenz @tresf