"ERROR topgrade::steps::containers" but summary "Containers: OK"

[thomas-merz]

What did you expect to happen?

Today I've seen an "ERROR topgrade::steps::containers".
I also expect summary to show "Containers: FAILED".

What actually happened?

"Containers: OK"

Additional details

• MacOS Monterey 12.4
• brew install topgrade

$ topgrade --no-retry  --disable atom --disable cargo --disable node --disable vim --disable system -v
…
 2022-06-20T10:24:42.652Z DEBUG topgrade::steps::containers > Pulling container 'gsh:latest'
 2022-06-20T10:24:42.652Z DEBUG topgrade::executor          > Running "/usr/local/bin/docker" "pull" "gsh:latest"
Error response from daemon: pull access denied for gsh, repository does not exist or may require 'docker login': denied: requested access to the resource is denied
 2022-06-20T10:24:44.610Z ERROR topgrade::steps::containers > Pulling container 'gsh:latest' failed: exit status: 1
 2022-06-20T10:24:46.567Z WARN  topgrade::steps::containers > Skipping unknown container 'gsh:latest'
…
Containers: OK
…
 2022-06-20T10:25:16.743Z DEBUG topgrade::terminal          > Desktop notification: Topgrade finished successfully

[MCOfficer]

See #853 for context.

As I understand it, the gist is this: Images are not guaranteed to be pull-able. For example, i can create and tag a local image from a random dockerfile, and as long as the name is unique it cannot be pulled. One such image should not cause the entire step to be a failure, hence why pull failures are ignored.

[thomas-merz]

I understand your argumentation. But wouldn't it be much better and more user-/admin-friendly if the summary would show at least some "WARNING" for "Containers"?! 🤔

[thomas-merz]

@r-darwish , can you please give an update and/or feedback regarding this issue? Thank you very much 😃