Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Pandoc version installed by setup-pandoc #336

Closed
jennybc opened this issue Jul 21, 2021 · 9 comments
Closed

Update the Pandoc version installed by setup-pandoc #336

jennybc opened this issue Jul 21, 2021 · 9 comments
Milestone

Comments

@jennybc
Copy link
Member

jennybc commented Jul 21, 2021

This request is motivated by reprex maintenance, i.e. so I see weird stuff when or slightly before reprex users see it. I'd love to leave proactive Pandoc version testing to the rmarkdown maintainers, like @cderv. But it would be nice if a package that depends on Pandoc via an intermediary, like reprex, knows that it's testing on a version its users have (or will soon have).

Proposal: I think it might make sense to approximately tether the Pandoc version installed by setup-pandoc to whatever ships with the current preview version of the RStudio IDE.

Related to #187

@jimhester
Copy link
Member

We could probably increase the version.

Also in the meantime you can control the pandoc version you are using in your own workflows with

- uses: r-lib/actions/setup-pandoc@v1
  with:
    pandoc-version: '2.13' # or whatever version is currently in the preview

@cderv
Copy link
Contributor

cderv commented Jul 21, 2021

FWIW this is (using with) what we do in rmarkdown workflows by adding pandoc version to our matrix
https://github.com/rstudio/rmarkdown/blob/0af6b3556adf6e393b2da23c66c695724ea7bd2d/.github/workflows/R-CMD-check.yaml#L32

We also do that to be sure to test older versions (like the current default 2.7.3) even if setup-pandoc increase its default value.

Regarding Pandoc versions in IDE, current version in stable release and in preview is 2.11.4. For daily version, it is 2.14.1 now, and a release is scheduled soon I think.

@gaborcsardi
Copy link
Member

Are there any more changes any of you want to see for this?

@cderv
Copy link
Contributor

cderv commented Dec 10, 2021

The default pandoc installed in setup-pandoc is still 2.7.3.

RStudio IDE daily is now at 2.16.2 or the one before. Last release is 2.14.2 I think.

2.7.3 is kind of old in the Pandoc world. In almost all my usage of this, I am changing the Pandoc version install. So that is not a big deal, but every new project using this action is testing with an older Pandoc. I still think it would worth upgrading the default Pandoc version - but maybe in another tag ?

@gaborcsardi
Copy link
Member

I am happy to update it, which version should I update to?

@gaborcsardi
Copy link
Member

I changed it to 2.14.2 in v2: 453e4fb

Will that be OK?

@gaborcsardi gaborcsardi added this to the v2 milestone Dec 10, 2021
@cderv
Copy link
Contributor

cderv commented Dec 10, 2021

I am fine with any. I think we can make a rule of following RStudio IDE shipped version, which will soon be Quarto bundled version.

Currently, after a quick check:

  • RStudio release and preview are the same 2021.09.1+372 Ghost Orchid and it is in fact 2.14.0.3
  • RStudio daily 2022.01.0-daily+309 Prairie Trillium is 2.16.2 now

I don't know what is best to follow really. Probably last preview or stable release ?

@gaborcsardi
Copy link
Member

Yeah, IDK, either. I think for most people it does not matter, and for the people that care, they'll probably set the version manually. I'll just leave it as is now, it seems that it is slightly newer than the one in RStudio release.

@github-actions
Copy link

github-actions bot commented Nov 6, 2022

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue and include a link to this issue

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants