Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should pkgdown protect package names in {} when inside brackets? (formatted as code) #176

Open
strengejacke opened this issue Sep 29, 2023 · 1 comment
Labels
bug an unexpected problem or unintended behavior

Comments

@strengejacke
Copy link

I have a vignette, where I use {} as "token" indicators. One token is named stars, and pkgdown converts this into a link to the package website, because it happens to be a package name (see https://easystats.github.io/parameters/articles/model_parameters_print.html#changing-style-of-column-output), i.e. instead of {stars}, the vignettes renders it as stars (for reference, the affected line in the rdm file is https://github.com/easystats/parameters/blob/9c16fb2084448bb6063746073c2b2d9fa6e832c1/vignettes/model_parameters_print.Rmd#L264C24-L264C24).

My question is if this should be the desired behaviour, or if automated linking to packages should not be done inside backticks (i.e. when formatted as code)?

@maelle
Copy link
Contributor

maelle commented Oct 2, 2023

It's a downlit feature https://github.com/r-lib/downlit#features (that for some reason I believed didn't work all the time but I didn't write a reprex 😭 #158

@hadley hadley transferred this issue from r-lib/pkgdown Oct 30, 2023
@hadley hadley added the bug an unexpected problem or unintended behavior label Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug an unexpected problem or unintended behavior
Projects
None yet
Development

No branches or pull requests

3 participants