Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix channel rate limiter for ack messages #3230

Merged
merged 1 commit into from
Jul 27, 2021
Merged

Fix channel rate limiter for ack messages #3230

merged 1 commit into from
Jul 27, 2021

Conversation

acogoluegnes
Copy link
Contributor

No description provided.

@HoloRin
Copy link
Contributor

HoloRin commented Jul 26, 2021

@acogoluegnes I have updated some test timeouts based on the failures in the checks. A rebase should pick them up without conflict.

acogoluegnes added a commit to rabbitmq/rabbitmq-java-client that referenced this pull request Jul 26, 2021
@acogoluegnes
Disable global QoS temporarily
559c4cb 
Because of a regression in 3.9.x.

References rabbitmq/rabbitmq-server#3230
acogoluegnes added a commit to rabbitmq/rabbitmq-java-client that referenced this pull request Jul 26, 2021
@acogoluegnes
Disable global QoS temporarily
267c355 
Because of a regression in 3.9.x.

References rabbitmq/rabbitmq-server#3230

(cherry picked from commit 559c4cb)
acogoluegnes added a commit to rabbitmq/rabbitmq-java-client that referenced this pull request Jul 26, 2021
@acogoluegnes
Disable global QoS temporarily
02ccdc2 
Because of a regression in 3.9.x.

References rabbitmq/rabbitmq-server#3230

(cherry picked from commit 559c4cb)
@acogoluegnes acogoluegnes added this to the 3.9.1 milestone Jul 27, 2021
@gerhard
Copy link
Contributor

gerhard commented Jul 27, 2021 •
edited
Loading

This looks good to me. I kicked off the jobs again as there were failures in the last run. As soon as everything goes green, this is good to merge and backport to v3.9.x.

Does this need backporting to v3.8.x too? Which issue does this fix @acogoluegnes?

@michaelklishin
Copy link
Member

I think this is specific to v3.9.x.

@gerhard
Copy link
Contributor

gerhard commented Jul 27, 2021

@pjk25 does this fail often? Should we just re-run?

https://github.com/rabbitmq/rabbitmq-server/pull/3230/checks?check_run_id=3172111643#step:4:1487

@HoloRin
Copy link
Contributor

HoloRin commented Jul 27, 2021

does this fail often? Should we just re-run?

It looks like the only hard failure was for //deps/rabbit:unit_disk_monitor_mocks_SUITE, in the form of a timeout. We should in this case update the size attribute for that test (many tests have needed this treatment recently as an artificial timeout extension was set by buildbuddy until last week). I will do so in master.

@HoloRin
Copy link
Contributor

HoloRin commented Jul 27, 2021

The timeout for //deps/rabbit:unit_disk_monitor_mocks_SUITE has been adjusted in master with 68361d5

@HoloRin
Copy link
Contributor

HoloRin commented Jul 27, 2021

FYI I have clicked re-run as it seemed the most expedient way to address the failure. Should we hit another timeout, I would advise correcting it in master and rebasing this branch to pick up both corrections.

@gerhard gerhard merged commit 1b5c7e3 into master Jul 27, 2021
@gerhard gerhard deleted the fix-notify-limiter branch July 27, 2021 15:49
gerhard added a commit that referenced this pull request Jul 27, 2021
@gerhard
Merge pull request #3230 from rabbitmq/fix-notify-limiter
6c38f22 
Fix channel rate limiter for ack messages

(cherry picked from commit 1b5c7e3)
@gerhard
Copy link
Contributor

gerhard commented Jul 27, 2021

Backported to v3.9.x

@michaelklishin michaelklishin mentioned this pull request Jul 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.9.1
Development

Successfully merging this pull request may close these issues.
4 participants
@acogoluegnes @HoloRin @gerhard @michaelklishin