-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React 0.13 support (conflicting peerDependency) #16
Comments
You know you don't have to stop using |
@AsaAyers Yes I know. The problem is the dependency and peerDependency on React 0.12. Sorry, the issue should have been more descriptive to begin with. :) |
Yeah run into this too. 👍 |
+1 to this issue. It's preventing us from upgrading to react-0.13.x. Would you accept a pull request that updates the package.json? Or do you foresee incompatibilities with React 0.13.x? |
Had to remove react-a11y because of the peerDependency conflict. Would love to see this addressed, too. |
until #23 is merged:
|
+1 |
See #24. Instead of requiring react my branch has you pass in any version you want. It's available with several other fixes on npm as @asaayers/react-a11y |
Same issue for us. |
Same for me -- love this tool, btw. |
@ryanflorence is react-a11y still being supported? There are 10 open PRs. 4 of them are mine and would close 4 other PRs and 1 issue including this one. |
+1 This is a great tool! I'll be using @iam4x's work around in the mean time. |
+1 👍 |
Fixed by PR #28 |
@kloots can you please update npm with this PR? The package description still has the old documentation and continues to throw this error. |
That documentation is accurate for the version that is on npm. Once a new version is released that page will update automatically. |
Okay thanks for the info @AsaAyers! |
Don't know what to fix without react-a11y telling me. 😞
The text was updated successfully, but these errors were encountered: