Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React 0.13 support (conflicting peerDependency) #16

Closed
RickWong opened this issue Mar 12, 2015 · 17 comments · Fixed by #24
Closed

React 0.13 support (conflicting peerDependency) #16

RickWong opened this issue Mar 12, 2015 · 17 comments · Fixed by #24

Comments

@RickWong
Copy link

Don't know what to fix without react-a11y telling me. 😞

@AsaAyers
Copy link
Contributor

until we have a replacement for current mixin use cases and support for class property initializers in the language, we don't plan to deprecate React.createClass.

You know you don't have to stop using React.createClass. Mixins are far more powerful than inheritance, so I'm sticking with React.createClass until they solve mixins for ES6 classes.

@RickWong
Copy link
Author

@AsaAyers Yes I know. The problem is the dependency and peerDependency on React 0.12. Sorry, the issue should have been more descriptive to begin with. :)

@NickColley
Copy link

Yeah run into this too. 👍

@RickWong RickWong changed the title React 0.13 support React 0.13 support (conflicting peerDependency) Mar 20, 2015
@dennis-johnson-dev
Copy link

+1 to this issue. It's preventing us from upgrading to react-0.13.x. Would you accept a pull request that updates the package.json? Or do you foresee incompatibilities with React 0.13.x?

@pluma
Copy link

pluma commented Apr 9, 2015

Had to remove react-a11y because of the peerDependency conflict. Would love to see this addressed, too.

@iam4x
Copy link

iam4x commented Apr 14, 2015

until #23 is merged:

  • npm install --save-dev iam4x/react-a11y#packaged

@yidea
Copy link

yidea commented Apr 18, 2015

+1

@AsaAyers
Copy link
Contributor

See #24. Instead of requiring react my branch has you pass in any version you want. It's available with several other fixes on npm as @asaayers/react-a11y

@necolas
Copy link

necolas commented Apr 28, 2015

Same issue for us.

@bmcmahen
Copy link

bmcmahen commented May 1, 2015

Same for me -- love this tool, btw.

@AsaAyers
Copy link
Contributor

AsaAyers commented May 1, 2015

@ryanflorence is react-a11y still being supported? There are 10 open PRs. 4 of them are mine and would close 4 other PRs and 1 issue including this one.

@mmrtnz
Copy link

mmrtnz commented May 1, 2015

+1 This is a great tool! I'll be using @iam4x's work around in the mean time.

@mathieumg
Copy link

+1 👍

@kloots
Copy link
Collaborator

kloots commented May 13, 2015

Fixed by PR #28

@kloots kloots closed this as completed May 13, 2015
@mmrtnz
Copy link

mmrtnz commented May 15, 2015

@kloots can you please update npm with this PR? The package description still has the old documentation and continues to throw this error.

@AsaAyers
Copy link
Contributor

That documentation is accurate for the version that is on npm. Once a new version is released that page will update automatically.

@mmrtnz
Copy link

mmrtnz commented May 15, 2015

Okay thanks for the info @AsaAyers!

erin-doyle pushed a commit that referenced this issue Nov 14, 2017
erin-doyle pushed a commit that referenced this issue Nov 14, 2017
erin-doyle pushed a commit that referenced this issue Nov 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.